Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754414AbYGBXLd (ORCPT ); Wed, 2 Jul 2008 19:11:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751916AbYGBXLY (ORCPT ); Wed, 2 Jul 2008 19:11:24 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:36394 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbYGBXLX (ORCPT ); Wed, 2 Jul 2008 19:11:23 -0400 Date: Wed, 2 Jul 2008 16:07:42 -0700 From: Greg KH To: Anton Vorontsov Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, Kay Sievers , Cornelia Huck , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/04] s390: bus_id -> dev_set_name() changes Message-ID: <20080702230742.GA708@kroah.com> References: <20080702154811.GB31083@kroah.com> <20080702221401.GA15142@zarina> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080702221401.GA15142@zarina> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 50 On Thu, Jul 03, 2008 at 02:14:01AM +0400, Anton Vorontsov wrote: > On Wed, Jul 02, 2008 at 08:48:11AM -0700, Greg KH wrote: > > From: Cornelia Huck > > > > Convert most s390 users setting bus_id to dev_set_name(). > > css and ccw busses are deferred since they need some special > > treatment. > > > > Signed-off-by: Cornelia Huck > > Cc: Kay Sievers > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/s390/block/dcssblk.c | 2 +- > > drivers/s390/char/vmlogrdr.c | 3 +-- > > drivers/s390/cio/ccwgroup.c | 3 +-- > > drivers/s390/cio/chp.c | 3 +-- > > drivers/s390/cio/css.c | 4 ++-- > > drivers/s390/crypto/ap_bus.c | 4 ++-- > > drivers/s390/net/netiucv.c | 2 +- > > drivers/s390/s390_rdev.c | 2 +- > > drivers/s390/scsi/zfcp_aux.c | 23 ++++++++--------------- > > 9 files changed, 18 insertions(+), 28 deletions(-) > > > > --- a/drivers/s390/block/dcssblk.c > > +++ b/drivers/s390/block/dcssblk.c > > @@ -349,7 +349,7 @@ dcssblk_add_store(struct device *dev, st > > } > > > > strcpy(dev_info->segment_name, local_buf); > > - strlcpy(dev_info->dev.bus_id, local_buf, BUS_ID_SIZE); > > + dev_set_name(&dev_info->dev, local_buf); > > As I see it, dev_set_name accepts printf like string, so this > dev_set_name is quite dangerous (since local_buf is formed > by the module param), no? So you would rather see: dev_set_name(&dev_info->dev, "%s", local_buf); instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/