Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761262AbYGCM5D (ORCPT ); Thu, 3 Jul 2008 08:57:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757973AbYGCM4u (ORCPT ); Thu, 3 Jul 2008 08:56:50 -0400 Received: from mtagate6.uk.ibm.com ([195.212.29.139]:15419 "EHLO mtagate6.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759499AbYGCM4t (ORCPT ); Thu, 3 Jul 2008 08:56:49 -0400 Message-ID: <486CCC4A.8050909@fr.ibm.com> Date: Thu, 03 Jul 2008 14:55:38 +0200 From: Daniel Lezcano User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Tejun Heo , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Andrew Morton , Benjamin Thery Subject: Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory support. References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 34 Eric W. Biederman wrote: > Daniel Lezcano writes: > >> The kobject events are sent through a netlink message which is not currently per >> network namespace. Shouldn't be useful to have a way to retrieve from the >> kobject the network namespace or the uevent socket associated with it ? IMHO >> having idr in the kobject + netns pointer associated may help to handle the >> sysfs isolation and makes the uevent per namespace trivial, no ? > > Grumble. I have been conveniently been forgetting about that socket. > Similarly we have the user mode helpers to deal with. > > For this conversation there is a simple answer. All of that is in the > kobject layer, and works even when you compile sysfs out of your kernel. > Therefore it is a separate problem. And sysfs idr tags have nothing > to do with it. Ah Ok, I am not really familiar with kobject/sysfs so I thought there was a proposition to store the id in the kobject instead of using the tag callbacks, so I figured, perhaps, the idr could have been used in the kobject layer and the sysfs being built upon that. > It is most definitely something we need to come back to. I bet there > are some interesting interactions when you have multiple network devices > with the same name generating events. Yes as mentionned Benjamin, we have the eth0 in the init_net which is shut down when a network namespace with a netdev with the same name exits. There is a udev rule which ifdown eth0 :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/