Date: Thu, 3 Jul 2008 14:32:44 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sedji Gaouaou <sedji.gaouaou@atmel.com>
Cc: Andrew Victor <avictor.za@gmail.com>,
       linux-arm-kernel@lists.arm.linux.org.uk,
       VILCHEZ Patrice <Patrice.VILCHEZ@atmel.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC
Message-ID: <20080703133244.GB17201@flint.arm.linux.org.uk>
References: <4852324C.9000604@atmel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4852324C.9000604@atmel.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1417
Lines: 35

On Fri, Jun 13, 2008 at 10:39:40AM +0200, Sedji Gaouaou wrote:
> Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s SOC.
> 
> At91sam9g20 is an evolution of the at91sam9260 with a faster clock speed.
> We created a new board for this device but based the chip support directly
> on 9260 files with little updates.
> Here is the chip page on Atmel website :
> http://atmel.com/dyn/products/product_card.asp?part_id=4337

I'm not sure what's going on, but the patch submitted to the patch system
is different from the one in this message.  The patch in your message
applies to my 'at91' branch just fine.  The one in the patch system
doesn't.

Plus, the description in the patch system is way too long in terms of
line length.  Please wrap before column 72 unless you're quoting
program output.

> +/*
> + * MCI (SD/MMC)
> + */
> +static struct at91_mmc_data __initdata ek_mmc_data = {
> +	.slot_b		= 1,
> +	.wire4		= 1,
> +//	.det_pin	= ... not connected
> +//	.wp_pin		= ... not connected
> +//	.vcc_pin	= ... not connected

Please make these a proper comment, preferably inside the comment before
the structure.  C++ comments are frowned upon in the kernel's source.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/