Message-ID: <486CDFE5.9030105@atmel.com>
Date: Thu, 03 Jul 2008 16:19:17 +0200
From: Sedji Gaouaou <sedji.gaouaou@atmel.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
CC: Andrew Victor <avictor.za@gmail.com>,
       linux-arm-kernel@lists.arm.linux.org.uk,
       VILCHEZ Patrice <Patrice.VILCHEZ@atmel.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-s
 SOC
References: <4852324C.9000604@atmel.com> <20080703133244.GB17201@flint.arm.linux.org.uk>
In-Reply-To: <20080703133244.GB17201@flint.arm.linux.org.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 30

Hi Andrew,
>   
>> +/*
>> + * MCI (SD/MMC)
>> + */
>> +static struct at91_mmc_data __initdata ek_mmc_data = {
>> +	.slot_b		= 1,
>> +	.wire4		= 1,
>> +//	.det_pin	= ... not connected
>> +//	.wp_pin		= ... not connected
>> +//	.vcc_pin	= ... not connected
>>     
>
> Please make these a proper comment, preferably inside the comment before
> the structure.  C++ comments are frowned upon in the kernel's source.
>
>   
I would like to know what do you suggest about this comment? Indeed we 
already use this kind of comments, for instance in board-sam9260ek.c. I 
don't mind changing it into the proper comment form, but I would like to 
know first what do you suggest.

Regards,
Sedji

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/