Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966AbYGCRdU (ORCPT ); Thu, 3 Jul 2008 13:33:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753106AbYGCRdJ (ORCPT ); Thu, 3 Jul 2008 13:33:09 -0400 Received: from www.church-of-our-saviour.ORG ([69.25.196.31]:48178 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752481AbYGCRdI (ORCPT ); Thu, 3 Jul 2008 13:33:08 -0400 Date: Thu, 3 Jul 2008 13:30:40 -0400 From: Theodore Tso To: David Woodhouse Cc: Jeff Garzik , Hugh Dickins , Andrew Morton , KOSAKI Motohiro , mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" Message-ID: <20080703173040.GB30506@mit.edu> Mail-Followup-To: Theodore Tso , David Woodhouse , Jeff Garzik , Hugh Dickins , Andrew Morton , KOSAKI Motohiro , mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org References: <20080703020236.adaa51fa.akpm@linux-foundation.org> <20080703205548.D6E5.KOSAKI.MOTOHIRO@jp.fujitsu.com> <486CC440.9030909@garzik.org> <486CCFED.7010308@garzik.org> <1215091999.10393.556.camel@pmac.infradead.org> <486CD654.4020605@garzik.org> <1215093175.10393.567.camel@pmac.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1215093175.10393.567.camel@pmac.infradead.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1897 Lines: 39 On Thu, Jul 03, 2008 at 02:52:55PM +0100, David Woodhouse wrote: > > After feedback from a number of people, there is no individual Kconfig > option for the various firmwares; there is only one which controls them > all -- CONFIG_FIRMWARE_IN_KERNEL. The thing you're whining about isn't > even part of the patch which needs review. > > > Because of your stubborn refusal on this Kconfig defaults issue, WE > > ALREADY HAVE DRIVER-DOES-NOT-WORK BREAKAGE, JUST AS PREDICTED. > > I strongly disagree that CONFIG_FIRMWARE_IN_KERNEL=y should be the > default. But if I add this patch elsewhere in the kernel, will you quit > your whining and actually review the patch you were asked to review? ... I don't think it's whining. If your patch introduces changes which cause people .config to break by default after upgrading to a newer kernel and doing "make oldconfig" --- then that's a problem with your patch, and the missing hunk to enable CONFIG_FIRMWARE_IN_KERNEL=y is critically important. Linus has ruled this way in the past, when he's gotten screwed by this sort of issue in the past, and he was justifiably annoyed. We should treat the users who are willing to test and provide feedback on the latest kernel.org kernels with the same amount of regard. And if there are licensing religious fundamentalists who feel strongly about the firmware issue, then fine, they can change the .config. But the default should be to avoid users from having broken kernels, and a number of (quite clueful) users have already demonstrated that without setting CONFIG_FIRMWARE_IN_KERNEL=y as the default, your patches cause breakage. Regards, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/