Message-Id: <200807040027.m640RQSx006004@po-mbox300.hop.2iij.net>
Date: Fri, 4 Jul 2008 09:28:42 +0900
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: yoichi_yuasa@tripeaks.co.jp, "Christoph Lameter" <cl@linux-foundation.org>,
       "Matt Mackall" <mpm@selenic.com>, linux-kernel@vger.kernel.org
Subject: Re: slub: Do not use 192 byte sized cache if minimum alignment is
 128 byte
In-Reply-To: <84144f020807030837k213e1880vf2d01bcf77e6886c@mail.gmail.com>
References: <486CDEC2.5030803@linux-foundation.org>
	<84144f020807030837k213e1880vf2d01bcf77e6886c@mail.gmail.com>
Organization: TriPeaks Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 26

On Thu, 3 Jul 2008 18:37:52 +0300
"Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

> On Thu, Jul 3, 2008 at 5:14 PM, Christoph Lameter
> <cl@linux-foundation.org> wrote:
> > The 192 byte cache is not necessary if we have a basic alignment of 128
> > byte. If it would be used then the 192 would be aligned to the next 128 byte
> > boundary which would result in another 256 byte cache. Two 256 kmalloc caches
> > cause sysfs to complain about a duplicate entry.
> >
> > MIPS needs 128 byte aligned kmalloc caches and spits out warnings on boot without
> > this patch.
> >
> > Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
> 
> Looks good to me. Yoichi, did you have the chance to test this?

I've already done.
It has no problem.

Yoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/