Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756667AbYGDNWz (ORCPT ); Fri, 4 Jul 2008 09:22:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752671AbYGDNWr (ORCPT ); Fri, 4 Jul 2008 09:22:47 -0400 Received: from fk-out-0910.google.com ([209.85.128.190]:6395 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbYGDNWp (ORCPT ); Fri, 4 Jul 2008 09:22:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=PcmK2ttcfQzoaCd1HvihPPhi2WA4KZPuPmO+a49sbAIIbVanfASs4Cy3N3VD3WeHHO uonT7C701vBlJ07xlm/VTC4REGvHk6pwOpKDVenZMT1mEJJfvgYuyMMrou2Q6c2VPWrZ nAxYsmxY48m5NCUDTkVE3VXdvUnMC1gzoPtaM= Date: Fri, 4 Jul 2008 17:22:35 +0400 From: Dmitry Baryshkov To: Takashi Iwai Cc: Stephen Rothwell , David Brownell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c Message-ID: <20080704132234.GA4576@doriath.ww600.siemens.net> References: <20080704114755.GA21747@doriath.ww600.siemens.net> <20080704124256.GB21747@doriath.ww600.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 55 On Fri, Jul 04, 2008 at 02:59:18PM +0200, Takashi Iwai wrote: > At Fri, 4 Jul 2008 16:42:56 +0400, > Dmitry Baryshkov wrote: > > > > On Fri, Jul 04, 2008 at 02:04:30PM +0200, Takashi Iwai wrote: > > > At Fri, 4 Jul 2008 15:47:55 +0400, > > > Dmitry Baryshkov wrote: > > > > > > > > On Fri, Jul 04, 2008 at 01:20:42PM +0200, Takashi Iwai wrote: > > > > > Fix the build of tc6393xb due to missing definition of struct > > > > > gpio_chip. > > > > > > > > > > Signed-off-by: Takashi Iwai > > > > > > > > > > --- > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > > index 9f93c29..2981da4 100644 > > > > > --- a/drivers/mfd/Kconfig > > > > > +++ b/drivers/mfd/Kconfig > > > > > @@ -44,7 +44,7 @@ config HTC_PASIC3 > > > > > > > > > > config MFD_TC6393XB > > > > > bool "Support Toshiba TC6393XB" > > > > > - depends on HAVE_GPIO_LIB > > > > > + depends on HAVE_GPIO_LIB && GENERIC_GPIO > > > > > select MFD_CORE > > > > > help > > > > > Support for Toshiba Mobile IO Controller TC6393XB > > > > > > > > Which configuration does provide HAVE_GPIO_LIB but not GENERIC_GPIO? > > > > > > The below is the config with which I got the error. > > > > The proper fix probably is to make PPC_MPC5200_GPIO also select > > GENERIC_GPIO. I don't think that building GPIO_LIB w/o GENERIC_GPIO > > should be supported. > > [Added David to Cc] > > Then HAVE_GPIO_LIB should depend on GENERIC_GPIO. > Or, linux/gpio.h should be fixed so that the code can be built > properly without GENERIC_GPIO. IIRC selected symbols don't propagate their depends. Also linux/gpio.h don't have anything in common with HAVE_GPIO_LIB. -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/