Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756294AbYGDN1Q (ORCPT ); Fri, 4 Jul 2008 09:27:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752964AbYGDN07 (ORCPT ); Fri, 4 Jul 2008 09:26:59 -0400 Received: from cantor.suse.de ([195.135.220.2]:41675 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbYGDN06 (ORCPT ); Fri, 4 Jul 2008 09:26:58 -0400 Date: Fri, 04 Jul 2008 15:26:55 +0200 Message-ID: From: Takashi Iwai To: David Woodhouse Cc: Hugh Dickins , Jeff Garzik , KOSAKI Motohiro , mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , netdev@vger.kernel.org Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" In-Reply-To: <1215177471.10393.753.camel@pmac.infradead.org> References: <20080703020236.adaa51fa.akpm@linux-foundation.org> <20080703205548.D6E5.KOSAKI.MOTOHIRO@jp.fujitsu.com> <486CC440.9030909@garzik.org> <1215177471.10393.753.camel@pmac.infradead.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 37 At Fri, 04 Jul 2008 14:17:51 +0100, David Woodhouse wrote: > > On Fri, 2008-07-04 at 13:06 +0200, Takashi Iwai wrote: > > Hmm, I got this error even with CONFIG_FIRMWARE_IN_KERNEL=y. > > > > Through a quick look at the code, the firmwares are not built indeed. > > I guess the fix like the following needed for building firmwares for > > modules. Now trying to build the kernel again to check this... > > For modules, you just need run > 'make INSTALL_FW_PATH=/lib/firmare firmware_install'. > > I should... > > 1. Change the default to /lib/firmware so that you don't have to set > INSTALL_FW_PATH. > 2. Add that to the 'make help' text. > 3. Look at making 'make modules_install' installl the firmware required > by the modules it's installing, so you don't even need to do > _anything_ new. Ah I see. I thought you implemented the built-in firmware even for modules, but apparently it's not. Is mkinitrd clever enough to put all needed firmware files to initrd automatically? Otherwise this can still break the existing setup... thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/