Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754850AbYGDUtd (ORCPT ); Fri, 4 Jul 2008 16:49:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752232AbYGDUtY (ORCPT ); Fri, 4 Jul 2008 16:49:24 -0400 Received: from mail.macqel.be ([194.78.208.39]:1494 "EHLO mail.macqel.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbYGDUtX (ORCPT ); Fri, 4 Jul 2008 16:49:23 -0400 Date: Fri, 4 Jul 2008 22:49:19 +0200 From: Philippe De Muyter To: Stefan Richter Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ieee1394 : dump mmapped video1394 buffers in core files Message-ID: <20080704204919.GA8991@frolo.macqel> References: <20080701132149.GA32510@frolo.macqel> <517f3f820807011116g6ce1b3e1qf166070f7a4c523f@mail.gmail.com> <20080702105027.GA1111@frolo.macqel> <486C4CC5.2060006@hitachi.com> <20080703093736.GA14369@frolo.macqel> <20080703165228.GA29373@frolo.macqel> <486E6CED.8060309@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <486E6CED.8060309@s5r6.in-berlin.de> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 35 On Fri, Jul 04, 2008 at 08:33:17PM +0200, Stefan Richter wrote: > Philippe De Muyter wrote: >> Currently, core files do not contain the mmapped memory of the video1394 >> or dv1394 devices, > > Ditto with /dev/raw1394 when the rawiso ioctl API is used. > >> which contain the actual video input, making it >> impossible to analyse the cause of abnormal program termination for >> image analysis or (de)compression software. Fix that. >> Signed-off-by: Philippe De Muyter >> --- >> diff -r ced66ca0044f drivers/ieee1394/dma.c >> --- a/drivers/ieee1394/dma.c Mon Jun 30 08:58:09 2008 -0700 >> +++ b/drivers/ieee1394/dma.c Thu Jul 3 18:40:24 2008 +0200 >> @@ -274,7 +274,7 @@ int dma_region_mmap(struct dma_region *d >> vma->vm_ops = &dma_region_vm_ops; >> vma->vm_private_data = dma; >> vma->vm_file = file; >> - vma->vm_flags |= VM_RESERVED; >> + vma->vm_flags |= VM_RESERVED | VM_ALWAYSDUMP; >> return 0; >> } > > I'll commit it with the title changed to "dump mmapped iso buffers in core > files" if that's OK. OK for me Philippe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/