Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbYGEEDQ (ORCPT ); Sat, 5 Jul 2008 00:03:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750793AbYGEEDB (ORCPT ); Sat, 5 Jul 2008 00:03:01 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:40802 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbYGEEDA (ORCPT ); Sat, 5 Jul 2008 00:03:00 -0400 Date: Sat, 5 Jul 2008 13:02:03 +0900 From: KAMEZAWA Hiroyuki To: Gerald Schaefer Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Yasunori Goto , Dave Hansen , Andy Whitcroft Subject: Re: [PATCH] Make CONFIG_MIGRATION available for s390 Message-Id: <20080705130203.e7df168c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1215183539.4834.12.camel@localhost.localdomain> References: <1215183539.4834.12.camel@localhost.localdomain> Organization: Fujitsu X-Mailer: Sylpheed 2.4.2 (GTK+ 2.10.11; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3226 Lines: 94 On Fri, 04 Jul 2008 16:58:59 +0200 Gerald Schaefer wrote: > Subject: [PATCH] Make CONFIG_MIGRATION available for s390 > > From: Gerald Schaefer > > We'd like to support CONFIG_MEMORY_HOTREMOVE on s390, which depends on > CONFIG_MIGRATION. So far, CONFIG_MIGRATION is only available with NUMA > support. > > This patch makes CONFIG_MIGRATION selectable for s390. When MIGRATION > is enabled w/o NUMA, the kernel won't compile because of a missing > "migrate" member in vm_operations_struct and a missing "policy_zone" > definition. To avoid this, those are moved from an "#ifdef CONFIG_NUMA" > section to "#ifdef CONFIG_MIGRATION". > > Signed-off-by: Gerald Schaefer > --- Maybe make sense Acked-by: KAMEZAWA Hiroyuki > > include/linux/mempolicy.h | 6 ++++-- > include/linux/mm.h | 2 ++ > mm/Kconfig | 2 +- > 3 files changed, 7 insertions(+), 3 deletions(-) > > Index: mylinux-git/include/linux/mempolicy.h > =================================================================== > --- mylinux-git.orig/include/linux/mempolicy.h > +++ mylinux-git/include/linux/mempolicy.h > @@ -62,6 +62,10 @@ enum { > > struct mm_struct; > > +#ifdef CONFIG_MIGRATION > +extern enum zone_type policy_zone; > +#endif > + > #ifdef CONFIG_NUMA > > /* > @@ -202,8 +206,6 @@ extern struct zonelist *huge_zonelist(st > struct mempolicy **mpol, nodemask_t **nodemask); > extern unsigned slab_node(struct mempolicy *policy); > > -extern enum zone_type policy_zone; > - > static inline void check_highest_zone(enum zone_type k) > { > if (k > policy_zone && k != ZONE_MOVABLE) > Index: mylinux-git/include/linux/mm.h > =================================================================== > --- mylinux-git.orig/include/linux/mm.h > +++ mylinux-git/include/linux/mm.h > @@ -193,6 +193,8 @@ struct vm_operations_struct { > */ > struct mempolicy *(*get_policy)(struct vm_area_struct *vma, > unsigned long addr); > +#endif > +#ifdef CONFIG_MIGRATION > int (*migrate)(struct vm_area_struct *vma, const nodemask_t *from, > const nodemask_t *to, unsigned long flags); > #endif > Index: mylinux-git/mm/Kconfig > =================================================================== > --- mylinux-git.orig/mm/Kconfig > +++ mylinux-git/mm/Kconfig > @@ -174,7 +174,7 @@ config SPLIT_PTLOCK_CPUS > config MIGRATION > bool "Page migration" > def_bool y > - depends on NUMA > + depends on NUMA || S390 > help > Allows the migration of the physical location of pages of processes > while the virtual addresses are not changed. This is useful for > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/