Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbYGEFlk (ORCPT ); Sat, 5 Jul 2008 01:41:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752911AbYGEFlW (ORCPT ); Sat, 5 Jul 2008 01:41:22 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:63433 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752684AbYGEFlV (ORCPT ); Sat, 5 Jul 2008 01:41:21 -0400 Message-ID: <486F091C.8050803@cn.fujitsu.com> Date: Sat, 05 Jul 2008 13:39:40 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Andrew Morton CC: LKML , "Serge E. Hallyn" , Pavel Emelianov Subject: [PATCH 2/2] devcgroup: fix permission check when adding entry to child cgroup Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 35 # cat devices.list c 1:3 r # echo 'c 1:3 w' > sub/devices.allow # cat sub/devices.list c 1:3 w As illustrated, the parent group has no write permission to /dev/null, so its child should not be allowed to add this write permission, which is documented in Documentation/controllers/devices.txt. Signed-off-by: Li Zefan --- security/device_cgroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index 1e2e28a..ddd92ce 100644 --- a/security/device_cgroup.c +++ b/security/device_cgroup.c @@ -300,7 +300,7 @@ static int may_access_whitelist(struct dev_cgroup *c, continue; if (whitem->minor != ~0 && whitem->minor != refwh->minor) continue; - if (refwh->access & (~(whitem->access | ACC_MASK))) + if (refwh->access & (~whitem->access)) continue; return 1; } -- 1.5.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/