From: Johannes Weiner <hannes@saeurebad.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs users
References: <87tzf5tu3z.fsf@skyscraper.fehenstaub.lan>
	<20080704134159.4dd9f74e@bike.lwn.net>
Date: Sat, 05 Jul 2008 11:36:44 +0000
In-Reply-To: <20080704134159.4dd9f74e@bike.lwn.net> (Jonathan Corbet's message
	of "Fri, 4 Jul 2008 13:41:59 -0600")
Message-ID: <878wwg4l6b.fsf@saeurebad.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1676
Lines: 44

Hi,

Jonathan Corbet <corbet@lwn.net> writes:

> On Fri, 04 Jul 2008 19:52:16 +0200
> Johannes Weiner <hannes@saeurebad.de> wrote:
>
>> +(add-hook 'c-mode-hook
>> +          (lambda ()
>> +            (let ((filename (buffer-file-name)))
>> +              ;; Enable kernel mode for the appropriate files
>> +              (when (and file
>> +                         (string-match "/usr/src/linux" filename))
>
> Shouldn't that be "(and filename ..." rather than "file"?

Whoops, you are right.

> A test for /usr/src/linux seems misplaced, though; I don't think a
> whole lot of people keep their kernel trees there anymore.  There must
> be a better heuristic one can use to figure out whether a kernel source
> file is being edited.

Is this really needed?  I think most people have their kernel trees in
one directory and I used /usr/src/linux explicitely because it is so
well known and whoever reads this snippet knows what to substitute it
for.

But perhaps it should be "~/src/linux-trees/" to emphasize that it it
matches everything descendant from this directory.

A heuristics seems overkill as this snippet is not distributed code that
needs to be portable but it is just a tip for ones .emacs.  I don't want
heuristics in my .emacs if I know exactly where my kernel trees are.

But then, we should remove the check for linux-files completely and make
people use this coding style for every code they write ;)

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/