Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755161AbYGERKe (ORCPT ); Sat, 5 Jul 2008 13:10:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752118AbYGERK1 (ORCPT ); Sat, 5 Jul 2008 13:10:27 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55547 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbYGERK0 (ORCPT ); Sat, 5 Jul 2008 13:10:26 -0400 Date: Sat, 5 Jul 2008 13:10:24 -0400 From: Christoph Hellwig To: Denys Vlasenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Deinline a few functions in mmap.c Message-ID: <20080705171024.GA4723@infradead.org> References: <200807051837.30219.vda.linux@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807051837.30219.vda.linux@googlemail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 19 On Sat, Jul 05, 2008 at 06:37:30PM +0200, Denys Vlasenko wrote: > #if defined(CONFIG_STACK_GROWSUP) || defined(CONFIG_IA64) > /* > * PA-RISC uses this for its stack; IA64 for its Register Backing Store. > * vma is the last one with address > vma->vm_end. Have to extend vma. > */ > #ifndef CONFIG_IA64 > -static inline > +static > #endif Unrelated note, but I think this ifdef should go. We've always prefered slightly less possible optimizations over horribly ugly ifdefs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/