Cc: LKML <linux-kernel@vger.kernel.org>, David Woodhouse <dwmw2@infradead.org>,
       kernelnewbies <kernelnewbies@nl.linux.org>,
       kernel-janitors <kernel-janitors@vger.kernel.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, lars@nocrew.org, tomas@nocrew.org
Message-Id: <A3D470E0-953E-40D6-BF5A-D06B76451154@nocrew.org>
From: Fredrik Noring <noring@nocrew.org>
To: Jaswinder Singh <jaswinder@infradead.org>
In-Reply-To: <1215253496.7816.7.camel@jaswinder.satnam>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v926)
Subject: Re: [PATCH] dsp56k: use request_firmware
Date: Sun, 6 Jul 2008 15:36:58 +0200
References: <1215253496.7816.7.camel@jaswinder.satnam>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 32

Hi Jaswinder,

5 jul 2008 kl. 12.24 skrev Jaswinder Singh:
> +	for (i = 0; i < fw->size; i + 3) {

Are you sure about "i + 3" in this loop? Isn't GCC complaining,  
something like "statement with no effect"?

> +Driver: ATARI_DSP56K - Atari DSP56k support
> +
> +File: dsp56k/bootstap.bin
> +
> +Licence: Unknown
> +
> +Found in hex form in kernel source.

I wrote this DSP56k assembler code in 1995. It's a trivial copy loop  
that loads the main DSP program into memory. Please consider it GPL  
like the driver code it came from.

A disassembler would easily recreate the original ~50 lines of  
assembler source code, in case you'd like to assemble it with the rest  
of kernel. :)

Thanks,
Fredrik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/