Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758755AbYGFPVX (ORCPT ); Sun, 6 Jul 2008 11:21:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757242AbYGFPVN (ORCPT ); Sun, 6 Jul 2008 11:21:13 -0400 Received: from casper.infradead.org ([85.118.1.10]:51918 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757036AbYGFPVL (ORCPT ); Sun, 6 Jul 2008 11:21:11 -0400 Subject: Re: [PATCH] dsp56k: use request_firmware From: Jaswinder Singh To: Fredrik Noring Cc: LKML , David Woodhouse , kernelnewbies , kernel-janitors , Alan Cox , lars@nocrew.org, tomas@nocrew.org In-Reply-To: References: <1215253496.7816.7.camel@jaswinder.satnam> Content-Type: text/plain; charset=utf8 Date: Sun, 06 Jul 2008 20:43:44 +0530 Message-Id: <1215357224.2817.2.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 47 Hello Fredrik, On Sun, 2008-07-06 at 15:36 +0200, Fredrik Noring wrote: > Hi Jaswinder, > > 5 jul 2008 kl. 12.24 skrev Jaswinder Singh: > > + for (i = 0; i < fw->size; i + 3) { > > Are you sure about "i + 3" in this loop? Isn't GCC complaining, > something like "statement with no effect"? > Fixed, Thanks. > > +Driver: ATARI_DSP56K - Atari DSP56k support > > + > > +File: dsp56k/bootstap.bin > > + > > +Licence: Unknown > > + > > +Found in hex form in kernel source. > > I wrote this DSP56k assembler code in 1995. It's a trivial copy loop > that loads the main DSP program into memory. Please consider it GPL > like the driver code it came from. > > A disassembler would easily recreate the original ~50 lines of > assembler source code, in case you'd like to assemble it with the rest > of kernel. :) > Fixed. Updated patch : http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4 Thanks for you comments. Thank you, Jaswinder Singh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/