Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759463AbYGFU3w (ORCPT ); Sun, 6 Jul 2008 16:29:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756788AbYGFU3n (ORCPT ); Sun, 6 Jul 2008 16:29:43 -0400 Received: from ag-out-0708.google.com ([72.14.246.243]:51712 "EHLO ag-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756696AbYGFU3m (ORCPT ); Sun, 6 Jul 2008 16:29:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=FYGOc104ZH6NZUwffTzkP1pj+rHQ0b93NeFM62xIyz64pEln7GQggBNJCupbrAlBJS uYKI0uO5bVB/jl5PgL6JOn1Sl89s+qQE3YRkNczOj5PcwD85F2r/gqsw38vIdQKXhDrE TrQLu9keWWSBLoXUkWKblsbh/OAGqH/xZzlGQ= Message-ID: Date: Mon, 7 Jul 2008 00:29:36 +0400 From: "Alexander Beregalov" To: "Randy Dunlap" Subject: Re: [PATCH] x86 setup.c: cleanup includes Cc: mingo@elte.hu, yhlu.kernel@gmail.com, tglx@linutronix.de, hpa@zytor.com, kernel-janitors@vger.kernel.org, "Linux Kernel Mailing List" In-Reply-To: <20080706105840.90ac5219.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080706105840.90ac5219.randy.dunlap@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 21 2008/7/6 Randy Dunlap : > Did you do these manually (by personal inspection) or by some tool? > If a tool, what tool/where is it? Thanks. It is a simple script like this: find . -name "*.h" -exec grep.sh {} \; find . -name "*.c" -exec grep.sh {} \; grep.sh: #!/bin/sh grep -H "^#include" $1|sed "s,/\*.\+,,"|grep -v ":$"|sort|uniq -c|grep -v "^ \+1:" I have found about 70-80 double inclusions, but most of them have reason for that and can not be removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/