Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 20 Jan 2002 11:31:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 20 Jan 2002 11:30:54 -0500 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.176.19]:14557 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id ; Sun, 20 Jan 2002 11:30:39 -0500 Date: Sun, 20 Jan 2002 17:29:26 +0100 (CET) From: Adrian Bunk X-X-Sender: bunk@mimas.fachschaften.tu-muenchen.de To: David Woodhouse cc: Momchil Velikov , Subject: Re: [PATCH] __linux__ and cross-compile In-Reply-To: <2385.1011543302@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Jan 2002, David Woodhouse wrote: >... > > But if yes please consider what the following parts of your patch change: > > -#ifndef __linux__ > > +#ifndef __KERNEL__ > > Well, if he hadn't explicitly mentioned that he made header files which > could be included by userspace use defined(__KERNEL__)||defined(__linux__) > then I'd understand what you meant. As it is, I don't. Please explain. This is part of his patch to drivers/scsi/aic7xxx/aic7xxx.c It's clear that code that is part of an "#ifndef __linux__" will never be included on any other OS than Linux. Is this also garuanteed for "#ifndef __KERNEL__"? > dwmw2 cu Adrian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/