Date: Mon, 07 Jul 2008 18:09:16 +0200
Message-ID: <s5hr6a5vfpv.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: David Brownell <david-b@pacbell.net>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
       Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c
In-Reply-To: <200807051013.10078.david-b@pacbell.net>
References: <s5hiqvlc2ut.wl%tiwai@suse.de>
	<200807040954.34838.david-b@pacbell.net>
	<20080705083122.GA7026@doriath.ww600.siemens.net>
	<200807051013.10078.david-b@pacbell.net>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 29

At Sat, 5 Jul 2008 10:13:09 -0700,
David Brownell wrote:
> 
> On Saturday 05 July 2008, Dmitry Baryshkov wrote:
> > 
> > > > I'm not sure whether it's a better fix at this moment.
> > > 
> > > Which platform is it which is trying to declare that it has
> > > an implementation (HAVE_GPIO_LIB) of an interface that it
> > > doesn't support (GENERIC_GPIO unset) ??
> > 
> > the powerpc with PPC_MPC52xx=y, PPC_MPC5200_GPIO=y
> 
> The most natural fix is to have the Kconfig for PPC_MPC52xx
> select both GENERIC_GPIO and HAVE_GPIO_LIB.

Yes.  I, however, still feel uneasy by the fact that the combination
GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work.  We should either fix
it to work or disallow the combination.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/