Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754920AbYGGQX6 (ORCPT ); Mon, 7 Jul 2008 12:23:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753541AbYGGQXu (ORCPT ); Mon, 7 Jul 2008 12:23:50 -0400 Received: from mail.suse.de ([195.135.220.2]:45262 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753509AbYGGQXt (ORCPT ); Mon, 7 Jul 2008 12:23:49 -0400 Date: Mon, 07 Jul 2008 18:23:44 +0200 Message-ID: From: Takashi Iwai To: David Brownell Cc: Dmitry Baryshkov , Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c In-Reply-To: <200807070919.05305.david-b@pacbell.net> References: <200807051013.10078.david-b@pacbell.net> <200807070919.05305.david-b@pacbell.net> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 34 At Mon, 7 Jul 2008 09:19:05 -0700, David Brownell wrote: > > On Monday 07 July 2008, Takashi Iwai wrote: > > > > > The most natural fix is to have the Kconfig for PPC_MPC52xx > > > select both GENERIC_GPIO and HAVE_GPIO_LIB. > > > > Yes. ?I, however, still feel uneasy by the fact that the combination > > GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work. ?We should either fix > > it to work or disallow the combination. > > As in, HAVE_GPIO_LIB depends on GENERIC_GPIO? Fine with me; > but I'm not sure that would work. Won't Kconfig gleefully let > the "select" succeed but not select what it depends on? No, it's a known problem of kbuild. You can use "select" for select. So, adding "select GENERIC_GPIO" to HAVE_GPIO_LIB should work. But, I'm not sure whether this is the right fix, too... Anyway, adding GENERIC_GPIO is fine as a workaround as now. I'll resubmit the fix patch. I just wanted you to keep the remaining problem in mind. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/