Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756480AbYGGTQu (ORCPT ); Mon, 7 Jul 2008 15:16:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754883AbYGGTQi (ORCPT ); Mon, 7 Jul 2008 15:16:38 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:45649 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754869AbYGGTQi (ORCPT ); Mon, 7 Jul 2008 15:16:38 -0400 Message-ID: <48726B7F.5010402@garzik.org> Date: Mon, 07 Jul 2008 15:16:15 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Alan Cox CC: David Woodhouse , Andi Kleen , David Miller , tytso@mit.edu, hugh@veritas.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" References: <1215093175.10393.567.camel@pmac.infradead.org> <20080703173040.GB30506@mit.edu> <1215111362.10393.651.camel@pmac.infradead.org> <20080703.162120.206258339.davem@davemloft.net> <486D6DDB.4010205@infradead.org> <87ej6armez.fsf@basil.nowhere.org> <1215177044.10393.743.camel@pmac.infradead.org> <486E2260.5050503@garzik.org> <1215178035.10393.763.camel@pmac.infradead.org> <486E2818.1060003@garzik.org> <1215179161.10393.773.camel@pmac.infradead.org> <486E2E9B.20200@garzik.org> <20080704153822.4db2f325@lxorguk.ukuu.org.uk> <48715807.8070605@garzik.org> <20080707165333.6347f564@the-village.bc.nu> <48725155.2040007@garzik.org> <20080707191359.11f6297f@the-village.bc.nu> <48726734.7080601@garzik.org> <20080707193008.17795d61@the-village.bc.nu> In-Reply-To: <20080707193008.17795d61@the-village.bc.nu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 37 Alan Cox wrote: > On Mon, 07 Jul 2008 14:57:56 -0400 > Jeff Garzik wrote: > >> Alan Cox wrote: >>>> When the firmware travels with the module, as it does today in tg3, bnx2 >>>> and others, is the most reliable system available. The simplest, the >>>> least amount of "parts", the easiest to upgrade, the best method to >>>> guarantee driver/firmware version matches. It works wonderfully today. >>>> >>>> Is it difficult to see why someone might want to keep the same attributes? >>> No I can see that, should be a simple matter of sending David patches. >> Isn't it David's obligation not to remove a highly reliable, working system? > > I don't see why it should be David's job to add every conceivable feature > to the code. Just whose job is it, exactly, to avoid regressions? Why is it unfair to ask a patch author not to break stuff? > And this is the pot calling the kettle black. You badly > broke Marvell PATA support by setting the Marvell SATA devices to AHCI. I > note you've still not fixed that after some months. Even if we accept that at face value, which I don't (it's more a driver load order issue), that is no excuse for further regressions. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/