Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758070AbYGGUPt (ORCPT ); Mon, 7 Jul 2008 16:15:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755661AbYGGUPk (ORCPT ); Mon, 7 Jul 2008 16:15:40 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:34596 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513AbYGGUPj (ORCPT ); Mon, 7 Jul 2008 16:15:39 -0400 From: "Rafael J. Wysocki" To: "Maciej W. Rozycki" Subject: Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for some HP systems Date: Mon, 7 Jul 2008 22:17:23 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Ingo Molnar , Matthew Garrett , Len Brown , Thomas Gleixner , linux-next@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen References: <200807070319.29470.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807072217.24590.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 48 On Monday, 7 of July 2008, Maciej W. Rozycki wrote: > On Mon, 7 Jul 2008, Rafael J. Wysocki wrote: > > > @@ -1714,12 +1721,14 @@ static inline void __init check_timer(vo > > apic2 = apic1; > > } > > > > - replace_pin_at_irq(0, 0, 0, apic1, pin1); > > - apic1 = 0; > > - pin1 = 0; > > - setup_timer_IRQ0_pin(apic1, pin1, cfg->vector); > > + if (disable_irq0_through_ioapic) { > > + clear_IO_APIC_pin(apic1, pin1); > > + } else { > > + replace_pin_at_irq(0, 0, 0, apic1, pin1); > > + apic1 = 0; > > + pin1 = 0; > > + setup_timer_IRQ0_pin(apic1, pin1, cfg->vector); > > > > - if (pin1 != -1) { > > /* > > * Ok, does IRQ0 through the IOAPIC work? > > */ > > This is completely broken -- you cannot blindly assume IRQ0 is wired to > the pin #0 of the I/O APIC #0. You have to respect routing information > provided by the system. > > Ingo, from the sequence above, I gather this code is currently in the > tree: > > - replace_pin_at_irq(0, 0, 0, apic1, pin1); > - apic1 = 0; > - pin1 = 0; > > Please revert the change which introduced it. While I recall posting a > patch which added code like this, I clearly stated it was solely for > diagnostics of Rafael's system and not to apply to any tree. Shouldn't the setup_timer_IRQ0_pin(apic1, pin1, cfg->vector) be removed as well? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/