Message-ID: <48729418.4000206@firstfloor.org>
Date: Tue, 08 Jul 2008 00:09:28 +0200
From: Andi Kleen <andi@firstfloor.org>
User-Agent: Thunderbird 1.5.0.12 (X11/20060911)
MIME-Version: 1.0
To: "H. Peter Anvin" <hpa@kernel.org>
CC: masbock@linux.vnet.ibm.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too
References: <200807041120.678642023@firstfloor.org> <48728A0E.7010802@kernel.org>
In-Reply-To: <48728A0E.7010802@kernel.org>
Content-Type: multipart/mixed;
 boundary="------------080101060301080904080604"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1828
Lines: 66

This is a multi-part message in MIME format.
--------------080101060301080904080604
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

H. Peter Anvin wrote:
> Andi Kleen wrote:
>> This patchkit uses the 64bit machine check code which is better in many
>> ways on 32bit x86 too. This is also the basis for some future machine
>> check work.
> 
> Hi Andi,
> 
> I tried applying your patch kit to -tip, but I'm getting build failures
> on i386; gcc-4.1.1-51.fc5.x86_64 with attached configuration.

Thanks for testing.

Your config seems to for some reason not do an implicit asm/apic.h
that the file relied on.

With this additional patch applied before the final unification
your config builds.

Also fixed the strtoull warnings.

I'm sending a new patch series.

-Andi


--------------080101060301080904080604
Content-Type: text/plain;
 name="include"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="include"

Add missing includes in mce_intel_64.c

In some i386 configurations these are not implicitely included.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
===================================================================
--- linux.orig/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
+++ linux/arch/x86/kernel/cpu/mcheck/mce_intel_64.c
@@ -12,6 +12,8 @@
 #include <asm/hw_irq.h>
 #include <asm/idle.h>
 #include <asm/therm_throt.h>
+#include <asm/apic.h>
+#include <asm/pda.h>
 
 asmlinkage void smp_thermal_interrupt(void)
 {

--------------080101060301080904080604--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/