Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755659AbYGHOs4 (ORCPT ); Tue, 8 Jul 2008 10:48:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753521AbYGHOst (ORCPT ); Tue, 8 Jul 2008 10:48:49 -0400 Received: from g1t0028.austin.hp.com ([15.216.28.35]:46819 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbYGHOss convert rfc822-to-8bit (ORCPT ); Tue, 8 Jul 2008 10:48:48 -0400 From: "Altobelli, David" To: Pavel Machek CC: "linux-kernel@vger.kernel.org" , "greg@kroah.com" Date: Tue, 8 Jul 2008 14:48:00 +0000 Subject: RE: [PATCH][resubmit] HP iLO driver Thread-Topic: [PATCH][resubmit] HP iLO driver Thread-Index: AcjgzYiI3XHCKmrHTF29vUSsDaYCKwAOBg8g Message-ID: References: <20080623160052.GA7616@ldl.fc.hp.com> <20080627191458.GA10872@ucw.cz> <20080707160658.GB1794@elf.ucw.cz> <20080708072152.GD1761@elf.ucw.cz> <20080708073818.GA14245@elf.ucw.cz> In-Reply-To: <20080708073818.GA14245@elf.ucw.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 30 Pavel Machek wrote: > It probably does configure passwords on the management processor, for > example? > > And for that functionality, something like > > echo new_password > /sys/hpilo/admin/password > > would make sense, right? Except that your interface is more like "echo > ^%TEWFSGFSDF^%EW&^Tadmin^*&S^F&*SDYF*&SDYF*&YE*Wnew_password(* > &DF&S^DF*&DS^F*&S >> /dev/hpilo/d0ccb0", right? (And except that you consider exact > string to echo to change password "proprietary secret"). > > We'd like to have the first interface, but unfortunately we do not > know enough about hpilo to even ask for better interface. Is the first interface really preferrable? How does that extend to commands that need to return data? Do we want to manage 30 different commands in the kernel? New functionality would require kernel updates. It seems much cleaner to keep the kernel interface simple and opaque (ie read/write), and handle the details of the commands in user space. >From my limited understanding, I thought that was a common goal here: move what you can to userspace. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/