Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757422AbYGILPt (ORCPT ); Wed, 9 Jul 2008 07:15:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753827AbYGILPi (ORCPT ); Wed, 9 Jul 2008 07:15:38 -0400 Received: from ipmail01.adl6.internode.on.net ([203.16.214.146]:58502 "EHLO ipmail01.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814AbYGILPh (ORCPT ); Wed, 9 Jul 2008 07:15:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAAA4dEh5LFxA/2dsb2JhbACwCg X-IronPort-AV: E=Sophos;i="4.30,331,1212330600"; d="scan'208";a="145208332" Date: Wed, 9 Jul 2008 21:15:26 +1000 From: Dave Chinner To: Miklos Szeredi Cc: arjan@infradead.org, hch@infradead.org, tytso@mit.edu, pavel@suse.cz, t-sato@yk.jp.nec.com, akpm@linux-foundation.org, viro@ZenIV.linux.org.uk, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, mtk.manpages@googlemail.com Subject: Re: [PATCH 3/3] Add timeout feature Message-ID: <20080709111526.GU11558@disturbed> Mail-Followup-To: Miklos Szeredi , arjan@infradead.org, hch@infradead.org, tytso@mit.edu, pavel@suse.cz, t-sato@yk.jp.nec.com, akpm@linux-foundation.org, viro@ZenIV.linux.org.uk, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, mtk.manpages@googlemail.com References: <20080709005254.GQ11558@disturbed> <20080709010922.GE9957@mit.edu> <20080709061621.GA5260@infradead.org> <20080708234120.5072111f@infradead.org> <20080709065950.GR11558@disturbed> <20080709073358.GT11558@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 45 On Wed, Jul 09, 2008 at 10:11:01AM +0200, Miklos Szeredi wrote: > On Wed, 9 Jul 2008, Dave Chinner wrote: > > On Wed, Jul 09, 2008 at 09:13:34AM +0200, Miklos Szeredi wrote: > > > On Wed, 9 Jul 2008, Dave Chinner wrote: > > > > The argument against Miklos' version is that there may be multiple > > > > commands to execute while the fs is frozen. > > > > > > Which is what a shell is for ;) > > > > Yeah, weĺl, with your method I ca't tell a user to: > > > > # xfs_freeze -f /mntpt > > # xfs_db -r -c 'sb 0' -c 'p rootino' /dev/foo > > 128 > > # xfs_db -r -c 'ino 128' -c 'p core.format' /dev/foo > > core.format = 2 (extents) > > # xfs_db ..... > > ..... > > # xfs_freeze -u /mntpt > > > > i.e. using the freeze to force all metadata to disk and > > prevent it from changing while doing interactive debugging > > of some problem. > > # run_freeze /mntpt /bin/bash > # ... > # ^D > > It's the same, no? For that case, yeah. But it's a horrible hack - if that's the best we can come up with for this freeze/unfreeze then we've already lost. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/