Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757670AbYGILQ6 (ORCPT ); Wed, 9 Jul 2008 07:16:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753834AbYGILQt (ORCPT ); Wed, 9 Jul 2008 07:16:49 -0400 Received: from rv-out-0506.google.com ([209.85.198.231]:18629 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbYGILQs (ORCPT ); Wed, 9 Jul 2008 07:16:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=F8wHAvBNxJ8CiBHTlSFMDdxR537wb3t9BzgBInPJE+nojIEp9AdthGO1KyD9atrEL1 2286wphJCRm55IHzTltXguGPHwBeA9y24J6SrufFUfvIViQJMl0jXqBSyRCRQq8zfe9z MGf6CDmNULQRGhUnu0U+dF7TpBgNO97FaPJBQ= Message-ID: Date: Wed, 9 Jul 2008 15:16:47 +0400 From: Dmitry To: "Ben Dooks" Subject: Re: [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure. Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, sameo@openedhand.com In-Reply-To: <20080709111215.GL8489@trinity.fluff.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080709104916.200210922@fluff.org> <20080709104932.905074060@fluff.org> <20080709111215.GL8489@trinity.fluff.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2000 Lines: 65 2008/7/9 Ben Dooks : > On Wed, Jul 09, 2008 at 03:09:12PM +0400, Dmitry wrote: >> 2008/7/9 Ben Dooks : >> > The enable,disable,suspend and resume entry in the struct mfd_cell >> > do not seem to be necessary as they should be handled by the >> > platform driver that the device created has bound to. >> >> NAK. It's used e.g. by the tmio-nand driver. These fields provide easy >> way to support >> enhanced power management, etc. > > What enhancements over the standard platform device model do you need? As an example of what we need, please check the tmio-nand driver. > >> > >> > Signed-off-by: Ben Dooks >> > >> > Index: linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h >> > =================================================================== >> > --- linux-2.6.26-rc9-next20080709.orig/include/linux/mfd/core.h 2008-07-09 10:44:45.000000000 +0100 >> > +++ linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h 2008-07-09 10:45:06.000000000 +0100 >> > @@ -23,12 +26,6 @@ >> > */ >> > struct mfd_cell { >> > const char *name; >> > - >> > - int (*enable)(struct platform_device *dev); >> > - int (*disable)(struct platform_device *dev); >> > - int (*suspend)(struct platform_device *dev); >> > - int (*resume)(struct platform_device *dev); >> > - >> > void *driver_data; /* driver-specific data */ >> > >> > /* >> > >> > -- >> > >> >> >> >> -- >> With best wishes >> Dmitry > > -- > -- > Ben > > Q: What's a light-year? > A: One-third less calories than a regular year. > > -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/