Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbYGIQWq (ORCPT ); Wed, 9 Jul 2008 12:22:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753455AbYGIQWh (ORCPT ); Wed, 9 Jul 2008 12:22:37 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:42463 "EHLO the-village.bc.nu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753454AbYGIQWg (ORCPT ); Wed, 9 Jul 2008 12:22:36 -0400 Date: Wed, 9 Jul 2008 16:49:29 +0100 From: Alan Cox To: David Howells Cc: "Miquel van Smoorenburg" , dhowells@redhat.com, akpm@linux-foundation.org, alan@redhat.com, Markus.Lidel@shadowconnect.com, vvs@sw.ru, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] Mark i2o config broken on 64-bit platforms. Message-ID: <20080709164929.799e4e05@the-village.bc.nu> In-Reply-To: <4561.1215612914@redhat.com> References: <20080709113547.19235.15424.stgit@warthog.procyon.org.uk> <4561.1215612914@redhat.com> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.8; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 23 On Wed, 09 Jul 2008 15:15:14 +0100 David Howells wrote: > Miquel van Smoorenburg wrote: > Maybe, but have you looked at i2o_cfg_passthru()? Take this, for example: > > /* Allocate memory for the transfer */ > p = kmalloc(sg_size, GFP_KERNEL); > ... > //TODO 64bit fix > sg[i].addr_bus = virt_to_bus(p); > > That looks distinctly dodgy. virt_to_bus() returns a 64-bit address, and as Agreed - stick | GFP_DMA32 on the end then ;) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/