Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbYGIRLk (ORCPT ); Wed, 9 Jul 2008 13:11:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751574AbYGIRLb (ORCPT ); Wed, 9 Jul 2008 13:11:31 -0400 Received: from tomts40.bellnexxia.net ([209.226.175.97]:48814 "EHLO tomts40-srv.bellnexxia.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751412AbYGIRLa (ORCPT ); Wed, 9 Jul 2008 13:11:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGGMdEhMQWVt/2dsb2JhbACBW69B Date: Wed, 9 Jul 2008 13:11:24 -0400 From: Mathieu Desnoyers To: Masami Hiramatsu Cc: akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Pekka Savola , netdev@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , Masami Hiramatsu , "'Peter Zijlstra'" , "Frank Ch. Eigler" , "'Hideo AOKI'" , Takashi Nishiie , "'Steven Rostedt'" , Eduard - Gabriel Munteanu Subject: [patch 15/15] LTTng instrumentation - ipv6 Message-ID: <20080709171124.GC12193@Krystal> References: <20080709145929.352201601@polymtl.ca> <4874EEF3.9010700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <4874EEF3.9010700@redhat.com> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 13:07:41 up 34 days, 21:48, 5 users, load average: 2.39, 1.94, 1.82 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3214 Lines: 101 * Masami Hiramatsu (mhiramat@redhat.com) wrote: > Hi Mathieu, > > I couldn't find your 15th patch in my mailbox, neither lkml archive. > Could you resend it? > > Thank you, > Sure, I think quilt had some problem with it because of a ill formatted email. Here it is. Instrument addr_add and del of network interfaces. Lets a tracer know the interface address changes. Those tracepoints are used by LTTng. About the performance impact of tracepoints (which is comparable to markers), even without immediate values optimizations, tests done by Hideo Aoki on ia64 show no regression. His test case was using hackbench on a kernel where scheduler instrumentation (about 5 events in code scheduler code) was added. See the "Tracepoints" patch header for performance result detail. Signed-off-by: Mathieu Desnoyers CC: Pekka Savola CC: netdev@vger.kernel.org CC: David S. Miller CC: Alexey Kuznetsov CC: Masami Hiramatsu CC: 'Peter Zijlstra' CC: "Frank Ch. Eigler" CC: 'Ingo Molnar' CC: 'Hideo AOKI' CC: Takashi Nishiie CC: 'Steven Rostedt' CC: Eduard - Gabriel Munteanu --- net/ipv6/addrconf.c | 4 ++++ net/ipv6/ipv6-trace.h | 14 ++++++++++++++ 2 files changed, 18 insertions(+) Index: linux-2.6-lttng/net/ipv6/addrconf.c =================================================================== --- linux-2.6-lttng.orig/net/ipv6/addrconf.c 2008-07-09 10:55:46.000000000 -0400 +++ linux-2.6-lttng/net/ipv6/addrconf.c 2008-07-09 10:58:43.000000000 -0400 @@ -85,6 +85,7 @@ #include #include +#include "ipv6-trace.h" /* Set to 3 to get tracing... */ #define ACONF_DEBUG 2 @@ -650,6 +651,8 @@ ipv6_add_addr(struct inet6_dev *idev, co /* For caller */ in6_ifa_hold(ifa); + trace_ipv6_addr_add(ifa); + /* Add to big hash table */ hash = ipv6_addr_hash(addr); @@ -2163,6 +2166,7 @@ static int inet6_addr_del(struct net *ne in6_ifa_hold(ifp); read_unlock_bh(&idev->lock); + trace_ipv6_addr_del(ifp); ipv6_del_addr(ifp); /* If the last address is deleted administratively, Index: linux-2.6-lttng/net/ipv6/ipv6-trace.h =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux-2.6-lttng/net/ipv6/ipv6-trace.h 2008-07-09 10:58:43.000000000 -0400 @@ -0,0 +1,14 @@ +#ifndef _IPV6_TRACE_H +#define _IPV6_TRACE_H + +#include +#include + +DEFINE_TRACE(ipv6_addr_add, + TPPROTO(struct inet6_ifaddr *ifa), + TPARGS(ifa)); +DEFINE_TRACE(ipv6_addr_del, + TPPROTO(struct inet6_ifaddr *ifa), + TPARGS(ifa)); + +#endif -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/