Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754476AbYGITxB (ORCPT ); Wed, 9 Jul 2008 15:53:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751074AbYGITwx (ORCPT ); Wed, 9 Jul 2008 15:52:53 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:53396 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbYGITwx (ORCPT ); Wed, 9 Jul 2008 15:52:53 -0400 Date: Wed, 9 Jul 2008 21:52:18 +0200 From: Ingo Molnar To: Jeremy Fitzhardinge Cc: LKML , x86@kernel.org, Stephen Tweedie , Eduardo Habkost , Mark McLoughlin , "Rafael J. Wysocki" Subject: Re: [patch] power, xen64: fix PM_SLEEP build dependencies (was: Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support) Message-ID: <20080709195218.GA9608@elte.hu> References: <20080709111219.GA24874@elte.hu> <20080709111621.GA2780@elte.hu> <20080709194753.GA8224@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080709194753.GA8224@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2148 Lines: 64 * Ingo Molnar wrote: > -tip testing found another PM/PM_SLEEP victim: > > arch/x86/kernel/built-in.o: In function `suspend': > apm_32.c:(.text+0xedb5): undefined reference to `save_processor_state' > apm_32.c:(.text+0xedd0): undefined reference to `restore_processor_state' ah, found it - the arch-level power/ directory had a CONFIG_PM-only build dependency as well. Fixed via the commit below. Ingo -------------> commit 6666fa5ebb7c78afcab540bf183c7f070c890930 Author: Ingo Molnar Date: Wed Jul 9 21:45:54 2008 +0200 power, xen64: fix PM_SLEEP build dependencies, #2 -tip testing found another PM/PM_SLEEP victim: arch/x86/kernel/built-in.o: In function `suspend': apm_32.c:(.text+0xedb5): undefined reference to `save_processor_state' apm_32.c:(.text+0xedd0): undefined reference to `restore_processor_state' with this config: http://redhat.com/~mingo/misc/config-Wed_Jul__9_18_53_45_CEST_2008.bad the core scenario is this combination (and only this combination) of config values: # CONFIG_PM is not set CONFIG_PM_SLEEP=y CONFIG_APM=y CONFIG_PARAVIRT=y CONFIG_XEN=y the problem is that the .o file where these symbols live does get built on PM_SLEEP=y, but the directory itself was only dependent on CONFIG_PM. Fix it by adding another rule that also covers the CONFIG_PM_SLEEP case. Signed-off-by: Ingo Molnar diff --git a/arch/x86/Makefile b/arch/x86/Makefile index fc698f2..4c85d09 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -175,6 +175,7 @@ drivers-$(CONFIG_OPROFILE) += arch/x86/oprofile/ # suspend and hibernation support drivers-$(CONFIG_PM) += arch/x86/power/ +drivers-$(CONFIG_PM_SLEEP) += arch/x86/power/ ifeq ($(CONFIG_X86_32),y) drivers-$(CONFIG_FB) += arch/x86/video/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/