Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756793AbYGIVDg (ORCPT ); Wed, 9 Jul 2008 17:03:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751489AbYGIVD2 (ORCPT ); Wed, 9 Jul 2008 17:03:28 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:60554 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbYGIVD1 (ORCPT ); Wed, 9 Jul 2008 17:03:27 -0400 Date: Wed, 9 Jul 2008 22:03:14 +0100 From: Russell King - ARM Linux To: Dmitry Cc: ian , linux-kernel@vger.kernel.org, Ben Dooks , linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Message-ID: <20080709210314.GF26734@flint.arm.linux.org.uk> References: <20080709104916.200210922@fluff.org> <20080709104933.101610936@fluff.org> <1215603916.3295.57.camel@wirenth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 32 On Wed, Jul 09, 2008 at 03:52:08PM +0400, Dmitry wrote: > 2008/7/9 ian : > > On Wed, 2008-07-09 at 15:15 +0400, Dmitry wrote: > >> NAK. > >> 0) It was discussed yesterday on the list and the decision was to go > >> in a different way. > > > > It was? > > > > I prefer the wrapped way personally... > > In any case IMO it's better to call platform_device_register() rather than > device_initialise()/platform_device_add(). > > Samuel? Russell? WTF??? That's just completely wrong - assuming the internals of how the platform device alloc API works... What it's clear from my *brief* read of this thread is that the MFD support doesn't seem to be ready for mainline yet - there's clearly issues here that need further work. Given that, and where we are (there's maybe two of *my* days left until the merge window opens) I'm *very* tempted to drop the MFD support out of my tree for this merge window - which basically means removing 5127/1, 5128/1 and 5129/1. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/