From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Theodore Tso <tytso@mit.edu>
Subject: Re: request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware())
Date: Wed, 9 Jul 2008 23:58:31 +0200
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: Pavel Machek <pavel@suse.cz>, David Miller <davem@davemloft.net>,
       alan@lxorguk.ukuu.org.uk, mchan@broadcom.com, dwmw2@infradead.org,
       bastian@waldi.eu.org, linux-kernel@vger.kernel.org
References: <20080707221950.3dfba435@the-village.bc.nu> <200807092313.55777.rjw@sisk.pl> <20080709212024.GB8517@mit.edu>
In-Reply-To: <20080709212024.GB8517@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200807092358.32605.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 24

On Wednesday, 9 of July 2008, Theodore Tso wrote:
> On Wed, Jul 09, 2008 at 11:13:54PM +0200, Rafael J. Wysocki wrote:
> > > Be careful about request_firmware. Doing it right w.r.t.
> > > suspend/resume is quite tricky: you have to load it from userspace
> > > before kernel starts, so that you can use it during resume...
> > 
> > Rather, you have to cache it in memory before your ->suspend() is invoked.
> 
> Translation: so much for saving "non-swappable kernel memory".
> Unless, of course we add a pre-suspend hook.  (Which doesn't exist
> yet, AFAICT from a quick perusal of Documentation/power/devices.txt.)

No, it doesn't.

You will be able to register a suspend notifier instead, but this requires
one fix which is in the works.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/