Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbYGIV6r (ORCPT ); Wed, 9 Jul 2008 17:58:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751125AbYGIV6k (ORCPT ); Wed, 9 Jul 2008 17:58:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44268 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbYGIV6i (ORCPT ); Wed, 9 Jul 2008 17:58:38 -0400 Date: Wed, 9 Jul 2008 14:52:53 -0700 From: Andrew Morton To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH v2] handle failure of irqchip->set_type in setup_irq Message-Id: <20080709145253.f658db37.akpm@linux-foundation.org> In-Reply-To: <20080709131353.GA12009@digi.com> References: <20080625131101.GA6205@digi.com> <20080704104634.GA31634@digi.com> <20080704101717.28f6a771.akpm@linux-foundation.org> <20080704184307.GA8076@digi.com> <20080704120837.573adc9c.akpm@linux-foundation.org> <20080709131353.GA12009@digi.com> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2162 Lines: 61 On Wed, 9 Jul 2008 15:13:53 +0200 Uwe Kleine-K__nig wrote: > Andrew Morton wrote: > > On Fri, 4 Jul 2008 20:43:07 +0200 Uwe Kleine-K__nig wrote: > > > > > > I wonder if we can do better. > > > > Let me think about that. > > > I was about to suggest something like: > > > > > > /* WARNING: this returns a static pointer, so you cannot use the > > > * returned value after another call to creative_function_name > > > */ > > > char *creative_function_name(void *addr) > > > { > > > static char buf[SOME_LENGTH]; > > > > > > ... format symbol name into buf ... > > > > > > return buf; > > > } > > > > > > Then I could have used > > > > > > pr_err("setting flow type for irq %u failed (%s)\n", > > > irq, creative_function_name(chip->set_type)); > > > > > > which looks definitely nicer. > > > > Better would be > > > > char buf[ENOUGH /* rofl */]; > > > > pr_err("setting flow type for irq %u failed (%s)\n", > > irq, render_function_name(buf, chip->set_type)); > > > > However I'm presently brewing up a plot to do this: > > > > printk("function name is %Ss\n", (unsigned long *)chip->set_type); > > > > which I think will work. We can also do > > > > printk("IP address is %Si\n", (unsigned long *)ip_address_buffer); > > > > to replace NIPQUAD. And similar printk extensions. > > > > Am still thinking about it though. > I assume the result is 0fe1ef24f7bd0020f29ffe287dfdb9ead33ca0b2? yup. > Should I send a new version using %pF or is it easier if you fix up the > patch? A new version would be nice, thanks. Or an incremental diff, but I can and will turn new versions into an incremental in the twinkle of an eye, so either is OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/