Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365AbYGJB5R (ORCPT ); Wed, 9 Jul 2008 21:57:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753344AbYGJB5E (ORCPT ); Wed, 9 Jul 2008 21:57:04 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51048 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752879AbYGJB5C (ORCPT ); Wed, 9 Jul 2008 21:57:02 -0400 Date: Wed, 9 Jul 2008 18:51:01 -0700 From: Andrew Morton To: Joerg Roedel Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, bhavna.sarathy@amd.com, Sebastian.Biemueller@amd.com, robert.richter@amd.com, joro@8bytes.org Subject: Re: [PATCH 12/34] AMD IOMMU: add detect code for AMD IOMMU hardware Message-Id: <20080709185101.94a8fefb.akpm@linux-foundation.org> In-Reply-To: <1214508490-29683-13-git-send-email-joerg.roedel@amd.com> References: <1214508490-29683-1-git-send-email-joerg.roedel@amd.com> <1214508490-29683-13-git-send-email-joerg.roedel@amd.com> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 25 On Thu, 26 Jun 2008 21:27:48 +0200 Joerg Roedel wrote: > This patch adds the detection of AMD IOMMU hardware provided on information > from ACPI provided by the BIOS. > > ... > > +static int __init init_iommu_all(struct acpi_table_header *table) > +{ > + u8 *p = (u8 *)table, *end = (u8 *)table; > + struct ivhd_header *h; > + struct amd_iommu *iommu; > + int ret; > + > + INIT_LIST_HEAD(&amd_iommu_list); Initialisation of a global list_head should be unnecessary. Just define the list_head with LIST_HEAD() and do it at compile-time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/