Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290AbYGJDOR (ORCPT ); Wed, 9 Jul 2008 23:14:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753594AbYGJDOF (ORCPT ); Wed, 9 Jul 2008 23:14:05 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:56237 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753582AbYGJDOE (ORCPT ); Wed, 9 Jul 2008 23:14:04 -0400 From: "Takashi Nishiie" To: "'Mathieu Desnoyers'" , , "'Ingo Molnar'" , , "'Peter Zijlstra'" Cc: "'Steven Rostedt'" , "'Thomas Gleixner'" , "'Masami Hiramatsu'" , "'Frank Ch. Eigler'" , "'Hideo AOKI'" , "'Eduard - Gabriel Munteanu'" References: <20080709145929.352201601@polymtl.ca> <20080709150045.025136754@polymtl.ca> <20080709153434.GA9186@Krystal> <20080709162158.GB10601@Krystal> <20080709190957.GA16779@Krystal> In-Reply-To: <20080709190957.GA16779@Krystal> Subject: RE: [PATCH] ftrace port to tracepoints (linux-next) Date: Thu, 10 Jul 2008 12:14:01 +0900 Message-ID: <010401c8e23b$020b6c30$06224490$@css.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 thread-index: Acjh94VSI4e6molBSHC3X1aU77hYJQAQccOA Content-Language: ja Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 38 Hi,Mathieu I think that it is wonderful that the source code becomes simple by changing kernel markers to tracepoints. However, it seems to forget to correct the error message. For example. Mathieu Wrote: >- ret = marker_probe_register("kernel_sched_wakeup", >- "pid %d state %ld ## rq %p task %p rq->curr %p", >- wake_up_callback, >- &ctx_trace); >+ ret = register_trace_sched_wakeup(probe_sched_wakeup); > if (ret) { > pr_info("wakeup trace: Couldn't add marker" > " probe to kernel_sched_wakeup\n"); > return ret; > } if (ret) { - pr_info("wakeup trace: Couldn't add marker" + pr_info("wakeup trace: Couldn't activate tracepoint" " probe to kernel_sched_wakeup\n"); return ret; } Thank you, -- Takashi Nishiie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/