Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755725AbYGJIIy (ORCPT ); Thu, 10 Jul 2008 04:08:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751354AbYGJIIi (ORCPT ); Thu, 10 Jul 2008 04:08:38 -0400 Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]:44163 "EHLO ch-smtp01.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbYGJIIg (ORCPT ); Thu, 10 Jul 2008 04:08:36 -0400 X-Greylist: delayed 1793 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Jul 2008 04:08:36 EDT Cc: Jaswinder Singh , LKML , kernelnewbies , kernel-janitors , Alan Cox , Lars Brinkhoff , =?ISO-8859-1?Q?Tomas_Sk=E4re?= Message-Id: From: Fredrik Noring To: David Woodhouse In-Reply-To: <1215608750.11567.177.camel@pmac.infradead.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: [PATCH] dsp56k: use request_firmware Date: Thu, 10 Jul 2008 09:38:36 +0200 References: <1215253496.7816.7.camel@jaswinder.satnam> <1215357224.2817.2.camel@jaswinder.satnam> <43A34816-3B93-4D05-AE0A-65C0FBF35589@nocrew.org> <1215358732.2817.11.camel@jaswinder.satnam> <1215363247.3189.113.camel@shinybook.infradead.org> <35647D7D-85D1-4308-B3A1-63CDCC3F14F7@nocrew.org> <1215608750.11567.177.camel@pmac.infradead.org> X-Mailer: Apple Mail (2.926) X-Originating-IP: 83.252.213.252 X-Scan-Result: No virus found in message 1KGqn3-0002aM-44. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KGqn3-0002aM-44 b3113cc7c13c98cfe088ec43b152ca60 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 40 Hi David, 9 jul 2008 kl. 15.05 skrev David Woodhouse: > It is in fact identical. Disassembly with the tools found on > sourceforge > was fun, since they have endianness bugs, don't recognise the 'JMP' > which was the first instruction, and need each 3-byte instruction in > the > binary to be prefixed with a zero byte to make it 4 bytes. But after > sorting that out and going through it instruction by instruction, it > really does seem to match. Heh. Amazing. [ I think the code can be simplified: It currently copies itself to a high program memory location, but this is not necessary because DSP soft reset was never implemented (the reset would have been trapped by the code, in order to load a new program). The driver instead power- cycles the DSP every time a new program is loaded. ] > Thanks very much for digging it out. No problem! > When you say 'GPL like the driver it came from', actually the driver > doesn't specify any version of the GPL but does refer to the top-level > COPYING file. So we'll take that to mean 'GPLv2 and not later', like > the > majority of the kernel. OK? OK with me. Thanks, Fredrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/