Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735AbYGJJ6g (ORCPT ); Thu, 10 Jul 2008 05:58:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753370AbYGJJ6P (ORCPT ); Thu, 10 Jul 2008 05:58:15 -0400 Received: from wf-out-1314.google.com ([209.85.200.171]:48667 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbYGJJ6N (ORCPT ); Thu, 10 Jul 2008 05:58:13 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=DMA+/xUtNCIOscyMb0C2pwFkhhNNc3v3HW1C4COXFcL8mZ3Kx8xE7mMNAxeOzQrPRb p2Y861vbE7unU0JoJRwMDnpKYxfHdhxweynh21Kg++Dd+zsHFgKL1nUYtDlWnkLcpoa6 uudiQJtLNzeLEmIlTILWBV53uI9ztCwF/ENpY= Message-ID: <19f34abd0807100258y1dfef681w7b293779fc1a12f4@mail.gmail.com> Date: Thu, 10 Jul 2008 11:58:11 +0200 From: "Vegard Nossum" To: "Mattias Nissler" , "Stefano Brivio" , "John W. Linville" , "David S. Miller" Subject: Re: [PATCH v2] rc80211_pid: Fix fast_start parameter handling Cc: "Ingo Molnar" , "Pekka Enberg" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org In-Reply-To: <1215464899.4416.22.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <19f34abd0807070427w5398c617uae0a4e8e40fd8f0e@mail.gmail.com> <1215464899.4416.22.camel@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 61 On Mon, Jul 7, 2008 at 11:08 PM, Mattias Nissler wrote: > This removes the fast_start parameter from the rc_pid parameters information > and instead uses the parameter macro when initializing the rc_pid state. Since > the parameter is only used on initialization, there is no point of making > exporting it via debugfs. This also fixes uninitialized memory references to > the fast_start and norm_offset parameters detected by the kmemcheck utility. > Thanks to Vegard Nossum for reporting the bug. > > Signed-off-by: Mattias Nissler > --- > > Updated patch description. Any more comments? Stefano? John? > > Mattias Hi, I've tested the patch now. This was my config: CONFIG_MAC80211_RC_DEFAULT_PID=y CONFIG_MAC80211_RC_PID=y and I'm using b43 driver successfully: CONFIG_B43=y CONFIG_B43_PCI_AUTOSELECT=y CONFIG_B43_PCICORE_AUTOSELECT=y CONFIG_B43_DEBUG=y This works too: # cat /debug/ieee80211/phy0/rc80211_pid/* 15 9 15 3 125 0 0 3 14 I guess you may put Tested-by: if this seems enough to verify that the patch causes no other harm. Can any of the net people acknowledge the reception of this patch? If it doesn't make it for 2.6.26, we should at least Cc stable. Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/