Date: Thu, 10 Jul 2008 05:59:03 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Arjan van de Ven <arjan@infradead.org>, tglx@linutronix.de,
       mingo@redhat.com, linux-kernel@vger.kernel.org,
       iommu@lists.linux-foundation.org, bhavna.sarathy@amd.com,
       Sebastian.Biemueller@amd.com, robert.richter@amd.com, joro@8bytes.org
Subject: Re: [PATCH 02/34] AMD IOMMU: add header file for driver data
 structures and defines
Message-Id: <20080710055903.e0776757.akpm@linux-foundation.org>
In-Reply-To: <20080710121221.GH14977@amd.com>
References: <1214508490-29683-1-git-send-email-joerg.roedel@amd.com>
	<1214508490-29683-3-git-send-email-joerg.roedel@amd.com>
	<20080709183823.52bbfd37.akpm@linux-foundation.org>
	<20080709185055.3b47c4db@infradead.org>
	<20080709193601.347134bf.akpm@linux-foundation.org>
	<20080710121221.GH14977@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1774
Lines: 44

On Thu, 10 Jul 2008 14:12:22 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:

> On Wed, Jul 09, 2008 at 07:36:01PM -0700, Andrew Morton wrote:
> > On Wed, 9 Jul 2008 18:50:55 -0700 Arjan van de Ven <arjan@infradead.org> wrote:
> > 
> > > On Wed, 9 Jul 2008 18:38:23 -0700
> > > Andrew Morton <akpm@linux-foundation.org> wrote:
> > > 
> > > > On Thu, 26 Jun 2008 21:27:38 +0200 Joerg Roedel
> > > > <joerg.roedel@amd.com> wrote:
> > > > 
> > > > > +/* helper macros */
> > > > > +#define LOW_U32(x) ((x) & ((1ULL << 32)-1))
> > > > > +#define HIGH_U32(x) (LOW_U32((x) >> 32))
> > > > 
> > > > Please avoid putting general-purpose helpers into private header
> > > > files.
> > > 
> > > especially broken helpers.
> > > 
> > > A >> 32 on something that may be a 32 bit entry is bad; int32 >> 32...
> > > gcc can (and does!) optimize that out.
> > > 
> > > (because it first gets translated into a SHR x86 instruction which then
> > > notices it's encoded as a zero shift.. which then gets deleted)
> > > 
> > 
> > Well yeah.  upper_32_bits() gets it all corect.  We could do a
> > lower_32_bits() I suppose, if it's useful.
> 
> Ok cool, I agree. I will replace the HIGH_U32 macro with the
> upper_32_bits() function and the other one with lower_32_bits() if it
> exists. Who will take the patch for the introduction of that function?
> 

I can do that.  We can slip it into mainline as soon as it's ready so that
the for-2.6.27 patches contine to work.

Or we can just do it later, as a followup thing.  Probably this is better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/