Date: Thu, 10 Jul 2008 15:31:36 +0200
From: Joerg Roedel <joerg.roedel@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
CC: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org,
       iommu@lists.linux-foundation.org, bhavna.sarathy@amd.com,
       Sebastian.Biemueller@amd.com, robert.richter@amd.com, joro@8bytes.org
Subject: Re: [PATCH 14/34] AMD IOMMU: clue initialization code together
Message-ID: <20080710133136.GQ14977@amd.com>
References: <1214508490-29683-1-git-send-email-joerg.roedel@amd.com> <1214508490-29683-15-git-send-email-joerg.roedel@amd.com> <20080709185512.6355159c.akpm@linux-foundation.org> <20080710123747.GK14977@amd.com> <20080710060351.770992cc.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20080710060351.770992cc.akpm@linux-foundation.org>
User-Agent: mutt-ng/devel-r804 (Linux)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1618
Lines: 44

On Thu, Jul 10, 2008 at 06:03:51AM -0700, Andrew Morton wrote:
> On Thu, 10 Jul 2008 14:37:47 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:
> 
> > > Is there a reason for using __get_free_pages() in this manner everywhere? 
> > > kmalloc() or kzalloc() are unsuitable?
> > 
> > Yes. The device table has to be page aligned and has a maximum size of
> > 2 MB. 
> 
> OK
> 
> > > > +	if (amd_iommu_dev_table == NULL)
> > > > +		goto out;
> > > > +
> > > > +	/*
> > > > +	 * Alias table - map PCI Bus/Dev/Func to Bus/Dev/Func the
> > > > +	 * IOMMU see for that device
> > > > +	 */
> > > > +	amd_iommu_alias_table = (void *)__get_free_pages(GFP_KERNEL,
> > > > +			get_order(alias_table_size));
> > 
> > Hmm, maybe this table will fit into a kmalloc allocation. Its maximum
> > size is 128 kb.
> 
> Might as well keep it all consistent in that case.

Yeah ok, I agree. Thanks for your review and comments. I try to push out
the updates today.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/