Date: Thu, 10 Jul 2008 21:52:49 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Robert Richter <robert.richter@amd.com>,
       Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci
Message-ID: <20080710195249.GB17255@uranus.ravnborg.org>
References: <1215709106-9182-1-git-send-email-robert.richter@amd.com> <20080710171721.GA19737@elte.hu> <20080710181234.GA32174@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080710181234.GA32174@elte.hu>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1945
Lines: 53

On Thu, Jul 10, 2008 at 08:12:34PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > * Robert Richter <robert.richter@amd.com> wrote:
> > 
> > > This patch series contains patches for tip/x86/unify-pci. It fixes 
> > > NUMA initialization code reflecting latest changes in tip/master. 
> > > Also there are build fixes and minor cleanups. Patch #5 is a cherry 
> > > pick that fixes build on UP systems. Code reboots for smp/nosmp, 
> > > acpi/noacpi, numaq, 32/64bit. It compiles for visws.
> > 
> > thanks Robert. Today i've eliminated the VISWS subarch which greatly 
> > simplified your series. I've picked up these two fixes:
> > 
> >  Robert Richter (2):
> >        x86/pci merge: fixing numaq initialization
> >        x86/pci: fix warnings in subsys_initcall functions
> 
> btw., this is how arch/x86/pci/Makefile looks like now in tip/master:
> 
> ----------------------------------------->
> pci-y                           := fixup.o
> pci-$(CONFIG_ACPI)              += acpi.o
> pci-y                           += legacy.o irq.o
> 
> pci-$(CONFIG_X86_VISWS)         += visws.o
> 
> pci-$(CONFIG_X86_NUMAQ)         += numa.o
> 
> obj-y                           += $(pci-y) common.o early.o
> obj-y                           += amd_bus.o
> <-----------------------------------------

So if I am not mistaken you can kill pci-y entirely:

obj-y                           := fixup.o
obj-$(CONFIG_ACPI)              += acpi.o
obj-y                           += legacy.o irq.o

obj-$(CONFIG_X86_VISWS)         += visws.o

obj-$(CONFIG_X86_NUMAQ)         += numa.o

obj-y                           += common.o early.o
obj-y                           += amd_bus.o

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/