Date: Thu, 10 Jul 2008 22:18:01 +0200
From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>, hpa@zytor.com,
       tglx@linutronix.de, akpm@linux-foundation.org, arjan@linux.intel.com,
       andi@firstfloor.org, jbarnes@virtuousgeek.org, steiner@sgi.com,
       linux-kernel@vger.kernel.org
Subject: Re: [patch 00/26] x64, x2apic/intr-remap: Interrupt-remapping and
	x2apic support
Message-ID: <20080710201801.GA6168@elte.hu>
References: <20080710181634.764954000@linux-os.sc.intel.com> <m1prplv71d.fsf@frodo.ebiederm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m1prplv71d.fsf@frodo.ebiederm.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 21


* Eric W. Biederman <ebiederm@xmission.com> wrote:

> A lot of your code is generic, and some of it is for just x86_64.  
> Since the cpus are capable of running in 32bit mode.  We really need 
> to implement x86_32 and x86_64 support in the same code base.  Which I 
> believe means factoring out pieces of io_apic_N.c into things such as 
> msi.c that can be shared between the two architectures.

i think the APIC code should be fully unified down the line - the 
APIC/IOAPIC knows little about the mode the CPU is running in and has to 
be programmed the same way independent of which mode the CPU is in. The 
current fork between the 32-bit and 64-bit APIC code is in good part 
artificial.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/