Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759076AbYGKCD1 (ORCPT ); Thu, 10 Jul 2008 22:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754096AbYGKCDT (ORCPT ); Thu, 10 Jul 2008 22:03:19 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42509 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbYGKCDT (ORCPT ); Thu, 10 Jul 2008 22:03:19 -0400 Date: Thu, 10 Jul 2008 19:02:25 -0700 (PDT) From: Linus Torvalds To: Roland McGrath cc: Ingo Molnar , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86_64: fix delayed signals In-Reply-To: Message-ID: References: <20080710215039.2A143154218@magilla.localdomain> <20080710224256.AD038154218@magilla.localdomain> <20080711005243.ADE90154218@magilla.localdomain> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 34 On Thu, 10 Jul 2008, Linus Torvalds wrote: > > So the x86-64 behaviour actually matches what the x86-32 behavior was at > the time before things split. > > And I'd also like to point out another commit, namely "[PATCH] fix broken > vm86 interrupt/signal handling" (4031ff388138b58e5cd472dccce38828bcb8c706) > that fixed a bug with an endless loop you had introduced in that original > x86-32 code when you fixed this exact same issue back when. > > Heh. That's the kind of thing that worries me. That said, seeing the full history of this same thing on the x86-32 side actually makes me _much_ happier about the patch. Because now I can tell when we did it, and what problems it seems to have caused (answer: "apparently none that are possibly relevant on x86-64"). IOW, just seeing the fact that we used to behave the same, and then changed it on the 32-bit side (with no apparent big issues) and did it without updating the 64-bit side, makes me just much happier about your patch. Just because I know know the background to why this was x86-64 only. So now I'm considering just putting it in before the 2.6.26 release after all ;) Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/