Date: Fri, 11 Jul 2008 10:54:07 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: linux-kernel@vger.kernel.org, the arch/x86 maintainers <x86@kernel.org>,
       James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [x86, patch] turn x86 VISWS into a generic architecture
Message-ID: <20080711085407.GB20987@elte.hu>
References: <20080710170712.GA14583@elte.hu> <20080711083946.GU7963@erda.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080711083946.GU7963@erda.amd.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 36


* Robert Richter <robert.richter@amd.com> wrote:

> On 10.07.08 19:07:12, Ingo Molnar wrote:
> 
> [...]
> 
> > diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> > index 99d9f09..e515e8d 100644
> > --- a/arch/x86/pci/Makefile
> > +++ b/arch/x86/pci/Makefile
> > @@ -9,9 +9,7 @@ pci-y				:= fixup.o
> >  pci-$(CONFIG_ACPI)		+= acpi.o
> >  pci-y				+= legacy.o irq.o
> >  
> > -# Careful: VISWS overrule the pci-y above. The colons are
> > -# therefor correct. This needs a proper fix by distangling the code.
> > -pci-$(CONFIG_X86_VISWS)		:= visws.o fixup.o
> > +pci-$(CONFIG_X86_VISWS)		+= visws.o
> 
> Ingo, if we turn this into generic code, we have to remove the 
> subsys_initcall for this too. Otherwise subsystem initialization is 
> running twice, in legacy.c and in visws.c.

Ok. Mind sending a patch for this against tip/master? Both your changes 
and the visws cleanups are all in there and are tested through on 
typical hardware.

(Also, there's the suggestion from Yinghai to first do the numa init.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/