Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597AbYGKKTA (ORCPT ); Fri, 11 Jul 2008 06:19:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751698AbYGKKSw (ORCPT ); Fri, 11 Jul 2008 06:18:52 -0400 Received: from mail37.messagelabs.com ([216.82.244.163]:45503 "EHLO mail37.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbYGKKSv (ORCPT ); Fri, 11 Jul 2008 06:18:51 -0400 X-VirusChecked: Checked X-Env-Sender: Uwe.Kleine-Koenig@digi.com X-Msg-Ref: server-10.tower-37.messagelabs.com!1215771529!5048945!1 X-StarScan-Version: 5.5.12.14.2; banners=-,-,- X-Originating-IP: [66.77.174.14] Date: Fri, 11 Jul 2008 12:18:39 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Magnus Damm CC: "linux-kernel@vger.kernel.org" , "gregkh@suse.de" , "akpm@linux-foundation.org" , "hjk@linutronix.de" , "lethal@linux-sh.org" , "tglx@linutronix.de" , "alan@lxorguk.ukuu.org.uk" Subject: Re: [PATCH] uio: uio_pdrv_genirq V3 Message-ID: <20080711101839.GA26106@digi.com> References: <20080711095527.6762.84233.sendpatchset@rx1.opensource.se> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080711095527.6762.84233.sendpatchset@rx1.opensource.se> User-Agent: Mutt/1.5.13 (2006-08-11) X-OriginalArrivalTime: 11 Jul 2008 10:18:42.0491 (UTC) FILETIME=[7E8158B0:01C8E33F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 21 Magnus Damm wrote: > - kept irq control spinlock to serialize user space access I think you want to assert, that after a succeeded echo 0 > /dev/uioX the userspace doesn't need to check for a pending irq?! What happens if the irq triggers before you take the lock? Best regards Uwe -- Uwe Kleine-K?nig, Software Engineer Digi International GmbH Branch Breisach, K?ferstrasse 8, 79206 Breisach, Germany Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/