Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755159AbYGKKXg (ORCPT ); Fri, 11 Jul 2008 06:23:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752131AbYGKKX2 (ORCPT ); Fri, 11 Jul 2008 06:23:28 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:44637 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbYGKKX2 (ORCPT ); Fri, 11 Jul 2008 06:23:28 -0400 Date: Fri, 11 Jul 2008 12:23:10 +0200 From: Ingo Molnar To: Sam Ravnborg Cc: Robert Richter , Thomas Gleixner , LKML Subject: Re: [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci Message-ID: <20080711102310.GA17033@elte.hu> References: <1215709106-9182-1-git-send-email-robert.richter@amd.com> <20080710171721.GA19737@elte.hu> <20080710181234.GA32174@elte.hu> <20080710195249.GB17255@uranus.ravnborg.org> <20080710195425.GB23322@elte.hu> <20080711082042.GT7963@erda.amd.com> <20080711102205.GA22725@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080711102205.GA22725@uranus.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 29 * Sam Ravnborg wrote: > > > > > > > > So if I am not mistaken you can kill pci-y entirely: > > > > Yes, but... > > > > > > > > > > obj-y := fixup.o > > > > ... this is with a plus: > > > > obj-y += fixup.o > > obj-y is empty when you enter the Makefile. > So if you start out with ':=' or '+=' is no difference. i guess it's safer to use +=, because it's ordering invariant. We should use := only if we absolutely want to override the current rules. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/