Subject: Re: [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver
From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>
In-Reply-To: <1215716683.17490.29.camel@localhost.localdomain>
References: <1215716683.17490.29.camel@localhost.localdomain>
Content-Type: text/plain; charset=utf-8
Date: Fri, 11 Jul 2008 11:28:07 +0100
Message-Id: <1215772087.6634.7.camel@odin>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 899
Lines: 43

On Thu, 2008-07-10 at 21:04 +0200, Philipp Zabel wrote:
> This adds a regulator driver for the TI bq24022 Single-Chip
> Li-Ion Charger with its nCE and ISET2 pins connected to GPIOs.

snip

> +static struct platform_driver bq24022_driver = {
> +	.driver = {
> +		.name = "bq24022",
> +	},
> +	.remove = __devexit_p(bq24022_remove),
> +};
> +
> +static int __init bq24022_init()

missing void

> +{
> +	platform_driver_probe(&bq24022_driver, bq24022_probe);
> +}
> +

missing return value.

> +static void __exit bq24022_exit()

﻿missing void

> +{
> +	platform_driver_unregister(&bq24022_driver);
> +}

Could you fix these and resubmit.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/