Date: Fri, 11 Jul 2008 19:19:35 +0200
From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: send correct MTU value in PMTU
Message-ID: <20080711171935.GA25603@hrz.tu-chemnitz.de>
References: <20080711124735.GA16996@hrz.tu-chemnitz.de> <20080711083423.64b67c0c@extreme>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/"
Content-Disposition: inline
In-Reply-To: <20080711083423.64b67c0c@extreme>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1493
Lines: 49


--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=utf8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 11, 2008 at 08:34:23AM -0700, Stephen Hemminger wrote:
> On Fri, 11 Jul 2008 14:47:35 +0200
> Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de> wrote:
>=20
> > [...]
>=20
>=20
> port should always be non-null so the existing fake_rtable can
> just go away no?

I wondered about that too. But since bridge_parent() is also checking port
for NULL, and the code calling this is carefully checking these cases, i
assumed that this is quite possible. If you can assert that port is
non-NULL, we can remove this, but i have to admit that i don't get the
whole picture to be sure about this.

>=20
> Also some of this could be #ifdef CONFIG_BRNETFILTER

Thanks, you're right. I will prepare the patch again with some #ifdefs.

regards,
	Simon

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFId5Ymrzg/fFk7axYRAr5EAJ9zm9U/mnvWlEexz2Wtx6pNu3H9QACg0t4S
kovqWcfGFCxpkJA8wGVd60g=
=Nqm4
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/