Date: Fri, 11 Jul 2008 12:18:33 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Guilak <guilak@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
       torvalds@linux-foundation.org, daniel@danielguilak.com
Subject: Re: [PATCH] init/version.c: Silenced sparse warning by declaring
 the version string.
Message-Id: <20080711121833.f03200e6.akpm@linux-foundation.org>
In-Reply-To: <1215552069.10304.6.camel@dguilak-desk>
References: <1215552069.10304.6.camel@dguilak-desk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1145
Lines: 39

On Tue, 08 Jul 2008 14:21:09 -0700 Daniel Guilak <guilak@linux.vnet.ibm.com> wrote:

> Signed-off-by: Daniel Guilak <daniel@danielguilak.com>

Please always quote the warning or error message in the changelog when
fixing it.  Although it's pretty obvious in this case.

>  init/version.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/init/version.c b/init/version.c
> index 9d17d70..041fd82 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -16,6 +16,7 @@
>  #define version(a) Version_ ## a
>  #define version_string(a) version(a)
>  
> +extern int version_string(LINUX_VERSION_CODE);
>  int version_string(LINUX_VERSION_CODE);
>  
>  struct uts_namespace init_uts_ns = {

hrm, what does this thing do?  Seems to define 

int Version_132634;

Then sticks that in the symbol table (and wastes a bit of bss).

Does anything use it?

Could it be made static?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/