Return-Path: <linux-kernel-owner+w=401wt.eu-S1757542AbYGKTka@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757542AbYGKTka (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Jul 2008 15:40:30 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756736AbYGKTkF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 11 Jul 2008 15:40:05 -0400
Received: from waste.org ([66.93.16.53]:47205 "EHLO waste.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756395AbYGKTkE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Jul 2008 15:40:04 -0400
Subject: Re: SL*B: drop kmem cache argument from constructor
From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jon Tollefson <kniht@linux.vnet.ibm.com>,
       Alexey Dobriyan <adobriyan@gmail.com>, penberg@cs.helsinki.fi,
       linux-mm@kvack.org, linux-kernel@vger.kernel.org,
       cl@linux-foundation.org, Nick Piggin <nickpiggin@yahoo.com.au>
In-Reply-To: <20080711122228.eb40247f.akpm@linux-foundation.org>
References: <20080710011132.GA8327@martell.zuzino.mipt.ru>
	 <48763C60.9020805@linux.vnet.ibm.com>
	 <20080711122228.eb40247f.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Fri, 11 Jul 2008 14:38:34 -0500
Message-Id: <1215805114.4800.55.camel@calx>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1768
Lines: 48


On Fri, 2008-07-11 at 12:22 -0700, Andrew Morton wrote:
> On Thu, 10 Jul 2008 11:44:16 -0500 Jon Tollefson <kniht@linux.vnet.ibm.com> wrote:
> 
> > Alexey Dobriyan wrote:
> > > Kmem cache passed to constructor is only needed for constructors that are
> > > themselves multiplexeres. Nobody uses this "feature", nor does anybody uses
> > > passed kmem cache in non-trivial way, so pass only pointer to object.
> > >
> > > Non-trivial places are:
> > > 	arch/powerpc/mm/init_64.c
> > > 	arch/powerpc/mm/hugetlbpage.c
> > >   
> > ...<snip>...
> > > --- a/arch/powerpc/mm/hugetlbpage.c
> > > +++ b/arch/powerpc/mm/hugetlbpage.c
> > > @@ -595,9 +595,9 @@ static int __init hugepage_setup_sz(char *str)
> > >  }
> > >  __setup("hugepagesz=", hugepage_setup_sz);
> > >
> > > -static void zero_ctor(struct kmem_cache *cache, void *addr)
> > > +static void zero_ctor(void *addr)
> > >  {
> > > -	memset(addr, 0, kmem_cache_size(cache));
> > > +	memset(addr, 0, HUGEPTE_TABLE_SIZE);
> > >   
> > This isn't going to work with the multiple huge page size support.  The
> > HUGEPTE_TABLE_SIZE macro now takes a parameter with of the mmu psize
> > index to indicate the size of page.
> > 
> 
> hrm.  I suppose we could hold our noses and use ksize(), assuming that
> we're ready to use ksize() at this stage in the object's lifetime.

ksize() on non-kmalloced objects is considered harmful. Doesn't work on SLOB.

> Better would be to just use kmem_cache_zalloc()?

I'd say so.

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/