Message-ID: <4877BA05.4000109@sandeen.net>
Date: Fri, 11 Jul 2008 14:52:37 -0500
From: Eric Sandeen <sandeen@sandeen.net>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
MIME-Version: 1.0
To: Sebastian Siewior <lkml@ml.breakpoint.cc>
CC: Dave Chinner <david@fromorbit.com>, Mikael Abrahamsson <swmike@swm.pp.se>,
       linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: xfs bug in 2.6.26-rc9
References: <alpine.DEB.1.10.0807110939520.30192@uplift.swm.pp.se> <20080711084248.GU29319@disturbed> <20080711190209.GA7401@Chamillionaire.breakpoint.cc>
In-Reply-To: <20080711190209.GA7401@Chamillionaire.breakpoint.cc>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1812
Lines: 44

Sebastian Siewior wrote:
> * Dave Chinner | 2008-07-11 18:42:49 [+1000]:
> 
>> Oh - you must be running a debug XFS.  CONFIG_XFS_DEBUG was only
>> introduced in 2.6.26-rc1 and defaults to 'N', so you must have
>> selected the non-default option when prompted. This will cause your
>> machine to oops at the slightest inconsistency that is found,
>> regardless of whether it is fatal or not. Like the help text says,
>> don't set this unless you are an XFS developer....
> Could you please add this to the Kconfig entry. Debug mode is usually
> noisy, little slower and mostly usefull just to the developers but *I*
> would not expect to BUG() in the non-fatal case.
> Not sure but if this is just for hch and you than a define in xfs.h
> might be safer :)
> 
>> Dave.
> Sebastian
> 
> 

heh, it ws hch who added the Kconfig option in the first place :)

> Back when I first submitted XFS for mainline inclusion we made the
> decision that the debug code is far to extensive to be accidentally
> enabled by users in mainline.  But then again it's often quite useful
> to track problems down and hacking the makefile all the time is rather
> annoying.  Given all the debug options with even more overhead like
> lockdep or DEBUG_PAGE_ALLOC users (or rather developers) should know
> by now what they're doing.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

But yeah, a bit more of a stern warning about the fatality of the debug
tests might be useful.  Just in case anyone reads that part and not the
"only use this if you are an xfs developer" part ;)

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/