Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757484AbYGKUKg (ORCPT ); Fri, 11 Jul 2008 16:10:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754539AbYGKUK1 (ORCPT ); Fri, 11 Jul 2008 16:10:27 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:37229 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754025AbYGKUK0 (ORCPT ); Fri, 11 Jul 2008 16:10:26 -0400 Date: Fri, 11 Jul 2008 22:09:57 +0200 From: Ingo Molnar To: Suresh Siddha Cc: "hpa@zytor.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "arjan@linux.intel.com" , "andi@firstfloor.org" , "ebiederm@xmission.com" , "jbarnes@virtuousgeek.org" , "steiner@sgi.com" , "linux-kernel@vger.kernel.org" , jeremy@goop.org Subject: Re: [patch 00/26] x64, x2apic/intr-remap: Interrupt-remapping and x2apic support Message-ID: <20080711200957.GA8173@elte.hu> References: <20080710181634.764954000@linux-os.sc.intel.com> <20080710195320.GA23322@elte.hu> <20080710215617.GM1678@linux-os.sc.intel.com> <20080711102814.GA17938@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080711102814.GA17938@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 33 * Ingo Molnar wrote: > > > http://redhat.com/~mingo/misc/config-Thu_Jul_10_21_43_28_CEST_2008.bad > > > > Ingo, that was my stupid typo. Please apply this patch. BTW, we need > > some more xen64 paravirt fixes in this area. I will look at it as > > soon as possible. > > applied to tip/x86/x2apic - thanks Suresh. another problem is the redefinition of apic_read(), causing: arch/x86/xen/enlighten.c: In function ‘xen_patch': arch/x86/xen/enlighten.c:1084: warning: label ‘patch_site' defined but not used arch/x86/xen/enlighten.c: At top level: arch/x86/xen/enlighten.c:1272: error: expected identifier before ‘(' token arch/x86/xen/enlighten.c:1273: error: expected ‘}' before ‘.' token with this config: http://redhat.com/~mingo/misc/config-Fri_Jul_11_21_51_18_CEST_2008.bad the continued spaghetti in all the APIC variants is quite ugly. This should all be handled via a single apic_ops template that should cover the paravirt and native variants as well. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/