Date: Fri, 11 Jul 2008 18:42:22 -0400
From: Andres Salomon <dilinger@queued.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Cortland Setlow <csetlow@tower-research.com>,
       corbet@lwn.net, video4linux-list@redhat.com,
       Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH resend] ov7670: clean up ov7670_read semantics
Message-ID: <20080711184222.5403dca9@fred>
In-Reply-To: <20080711151919.9cda44ea.akpm@linux-foundation.org>
References: <20080711165216.4dc32c4c@fred>
	<20080711151919.9cda44ea.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1077
Lines: 35

On Fri, 11 Jul 2008 15:19:19 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 11 Jul 2008 16:52:16 -0400 Andres Salomon
> <dilinger@queued.net> wrote:
> 
> > [note: this should probably go in for 2.6.26, as it fixes a bug in
> > ov7670_s_fmt where we incorrectly think that we've failed because we
> > return !0]
> > 
> 
> In which case 2.6.25.x wants the fix as well?
> 

Yep!

[...]
> > diff --git a/drivers/media/video/ov7670.c
> > b/drivers/media/video/ov7670.c index 2bc6bdc..d7bfd30 100644
> > --- a/drivers/media/video/ov7670.c
> > +++ b/drivers/media/video/ov7670.c
> > @@ -406,8 +406,10 @@ static int ov7670_read(struct i2c_client *c,
> > unsigned char reg, int ret;
> 
> You have some wordwrapping happening there.
> 

Eek, thanks.  The original send wasn't line-wrapped, I'm not sure how
that happened.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/